react-player-controls icon indicating copy to clipboard operation
react-player-controls copied to clipboard

Slider not draggable on iOS

Open scottyeung opened this issue 6 years ago • 7 comments

Checked on Chrome, slider bar is draggable but not in iOS.

scottyeung avatar Dec 15 '18 02:12 scottyeung

I missed to follow this up. Will have a look soon!

alexanderwallin avatar Jan 16 '19 20:01 alexanderwallin

we are seeing this as well. is this being addressed? or bigger fish to fry?

cyrdax avatar Mar 05 '19 23:03 cyrdax

I addressed it in https://github.com/alexanderwallin/react-player-controls/commits/touch-slider, but never tested it properly. If anyone has time to give it a go, that'd be super!

alexanderwallin avatar Mar 06 '19 14:03 alexanderwallin

Hello, did you get a chance to look at this?

sidwyn avatar Nov 15 '19 00:11 sidwyn

I created a fork here: https://github.com/arist0tl3/react-player-controls, which you can install with npm install @arist0tl3/react-player-controls.

Needed to get this working today, but I can open a PR here if anyone's interested.

As a heads up, you may need to add touch-action: none to prevent the default mobile browser click handling (https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action).

arist0tl3 avatar Sep 16 '20 22:09 arist0tl3

@arist0tl3 Thanks! Please create a PR and we'll get this into the lib!

alexanderwallin avatar Sep 17 '20 09:09 alexanderwallin

There's now a 2.0.0-beta.0 to try out!

alexanderwallin avatar Sep 25 '20 16:09 alexanderwallin