ranger_devicons icon indicating copy to clipboard operation
ranger_devicons copied to clipboard

Feature Request: Colored icons

Open ad-si opened this issue 6 years ago • 32 comments

It would be really color if there was an option to color the icons like in https://github.com/ryanoasis/vim-devicons

Any chance this gets implemented? :grin:

ad-si avatar May 07 '18 08:05 ad-si

Hi @ad-si Thanks for submitting this feature request. That looks pretty rad, I think we might be limited to the ranger colorschemes, but I'll see if this can be achieved using color escape codes and the likes.

alexanderjeurissen avatar May 07 '18 09:05 alexanderjeurissen

initial results don't seem very promising.. escape codes don't get interpreted by ranger but get printed directly.

Screenshot 2020-06-03 at 22 50 15

alexanderjeurissen avatar Jun 03 '20 20:06 alexanderjeurissen

I'll do some more investigation this weekend to see if I can get it to work.

alexanderjeurissen avatar Jun 03 '20 20:06 alexanderjeurissen

Did you manage to figure anything out for this?

CallumHoward avatar Jul 12 '20 14:07 CallumHoward

@CallumHoward not yet. Looks like Ranger completely ignores color escape codes. Also the font color of the linemode seems to be defined in the theme meaning ranger likely does not support partial highlights.

I'm open to suggestions and/or a PR.

alexanderjeurissen avatar Jul 12 '20 17:07 alexanderjeurissen

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Sep 11 '20 01:09 github-actions[bot]

Still relevant ;-)

ad-si avatar Sep 11 '20 08:09 ad-si

Uhm what? Why was it closed? What's the correct code word for the bot @alexanderjeurissen? 😅

ad-si avatar Sep 20 '20 19:09 ad-si

Seems one needs to remove the "stale issue" label explicitly.

For now I reopened the issue

alexanderjeurissen avatar Sep 20 '20 19:09 alexanderjeurissen

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Nov 20 '20 01:11 github-actions[bot]

bump

SuperSandro2000 avatar Nov 20 '20 08:11 SuperSandro2000

Thanks for the bump @SuperSandro2000

From my investigations it seems that this is not really feasible at this point in time.

Ranger does not support multi-colored output for its linemodes.

Font color for all text rendered in the linemode is defined by the 'theme'. This is a single color and does not support contextual coloring let alone multi-part color output.

As such, if people really want this feature I'd advise opening an issue upstream in the Ranger project.

alexanderjeurissen avatar Jan 02 '21 18:01 alexanderjeurissen

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Mar 04 '21 02:03 github-actions[bot]

Still relevant 😉

ad-si avatar Mar 04 '21 09:03 ad-si

The only way to get this working is if Ranger starts supporting ANSI escape codes / colors in line modes. Currently changing the color of individual items is limited to color schemes.

ref: https://github.com/ranger/ranger/issues/169 ref: https://github.com/ranger/ranger/issues/68

But those are limited in that highlighting takes place on a per line level.

@ad-si as the OP of this issue I urge you to create an issue upstream in the ranger project if this is something you really want. Without ranger supporting this there is nothing really that I can do.

alexanderjeurissen avatar Mar 04 '21 14:03 alexanderjeurissen

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar May 04 '21 01:05 github-actions[bot]

Bump

SuperSandro2000 avatar May 04 '21 11:05 SuperSandro2000

Bump Bump

UltiRequiem avatar May 14 '21 20:05 UltiRequiem

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Jul 14 '21 02:07 github-actions[bot]

bump bump bump (added upstream feature request)

CallumHoward avatar Jul 14 '21 02:07 CallumHoward

I have created a PR to add ANSI escape codes support in the ranger browser column, which makes it possible for colored icons or partially highlighted texts. See ranger/ranger#2445.

Screenshot

screencast

XuehaiPan avatar Sep 09 '21 14:09 XuehaiPan

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Nov 09 '21 02:11 github-actions[bot]

bump bump bump bump

UltiRequiem avatar Nov 09 '21 03:11 UltiRequiem

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Jan 09 '22 02:01 github-actions[bot]

BUMP!

UltiRequiem avatar Jan 09 '22 03:01 UltiRequiem

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Mar 12 '22 01:03 github-actions[bot]

bump

UltiRequiem avatar Mar 12 '22 02:03 UltiRequiem

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar May 12 '22 02:05 github-actions[bot]

ad-si avatar May 12 '22 07:05 ad-si

This issue has not seen any recent activity and therefore has been marked as stale. If the issue is no longer relevant, please attend the author so that the issue can be closed.

github-actions[bot] avatar Jul 12 '22 02:07 github-actions[bot]

I have been using @XuehaiPan's PR branch for 3 months now and it works without problem. I would love to see it reviewed and discussed so this cool feature can be merged and shared with everyone.

CallumHoward avatar Jul 12 '22 02:07 CallumHoward