Unified-Log-Processing icon indicating copy to clipboard operation
Unified-Log-Processing copied to clipboard

Bulletproof abandoned cart stream process() against bad input

Open jf opened this issue 9 years ago • 8 comments

jf avatar Feb 06 '16 09:02 jf

This is a good idea @jf - thanks for raising! Will merge when I get a chance to update the corresponding chapter...

alexanderdean avatar Feb 06 '16 10:02 alexanderdean

Sure, but fyi I discovered this myself when I tried to copy and paste some of the events from the pdf. The text as found in the pdf is such that some of those timestamps are invalid, which will cause a problem. e.g. the 2nd event on p.31: copied and pasted, there is a space in the timestamp, which apparently causes an error (and in the sku code too, but that's not a big deal because it doesn't cause any errors):

{ "event": "SHOPPER_ADDED_ITEM_TO_CART", "shopper": { "id": "762", "name": "Sue", "ipAddress": "65.34.103.11" }, "items": [ { "product": { "sku": "ms- 003", "name" : "XBox One" }, "quantity": 2 } ], "timestamp": "2015-09- 03T12:03:45Z" }

See that space between 2015-09-, and 03T...?

jf avatar Feb 06 '16 12:02 jf

(This is based on the 'Last saved: 1/18/2016' version, btw, in case you need to date it)

jf avatar Feb 06 '16 12:02 jf

Thanks @jf - will fix that in the manuscript!

alexanderdean avatar Feb 06 '16 19:02 alexanderdean

hi Alexander, would you mind just closing this issue once the manuscript has been fixed? Just so I know and can keep a lookout. Thanks!

jf avatar May 17 '16 16:05 jf

I will - thanks @jf

alexanderdean avatar May 17 '16 16:05 alexanderdean

hi Alexander, just to follow up on this (I don't have access to the manuscript just yet, so I can't verify it for myself) - did this ever get fixed?

jf avatar Jun 15 '17 18:06 jf

Not yet! It's still on the list. Thanks for reminding me...

alexanderdean avatar Jun 15 '17 21:06 alexanderdean