David Ankin

Results 93 comments of David Ankin

examples of how to omit the javax annotation here https://github.com/grpc/grpc-java/pull/10927#issuecomment-2066632469

When i was introduced to testcontainers at work the first time, we implemented logic to use local db and fall back on testcontainers; the api has changed and `reuse` is...

Currently it doesn't make too much of a difference what is merged or not, because there has been no activity in the repository from either individuals with Pypi publish credentials....

> Other than that, I'd like to point at the fact that while there may be several packages, only one is realistically released under sem-ver. i believe the relevant commit...

the matrix of lockfile predates this - imo it should go - it doesn't get shipped to the user, so it doesn't actually create a reproducible build when it matters....

thank you @smparekh for your contribution - we are favoring log based waiting now, so im closing this in favor of #461

the original links in the issue were from these two methods respectively https://github.com/testcontainers/testcontainers-python/blob/8119ccc1ceb240314bdd6c4ad896271abcbd66c9/testcontainers/core/docker_client.py#L52 from https://github.com/testcontainers/testcontainers-python/blob/8119ccc1ceb240314bdd6c4ad896271abcbd66c9/testcontainers/core/docker_client.py#L50-L54 and https://github.com/testcontainers/testcontainers-python/blob/8119ccc1ceb240314bdd6c4ad896271abcbd66c9/testcontainers/core/docker_client.py#L48 from https://github.com/testcontainers/testcontainers-python/blob/8119ccc1ceb240314bdd6c4ad896271abcbd66c9/testcontainers/core/docker_client.py#L43-L48

@pmpetit i believe this change is no longer necessary in oracle-free which we have moved our implementation to since the merge of #363 - if its still an issue, please...

Would a pr to restore the previous functionality be welcome or would that also require discussion? I am still interested in the main idea but I think in the meantime...