Alexander Held

Name validity checks in pyhf json2xml for ROOT compatibility

3

# Description `pyhf` supports names for `channels`, `samples`, and `modifiers` which would cause segmentation faults when used in ROOT. When building a workspace in `pyhf`, then running `pyhf json2xml` and...

`Workspace.build` does not propagate all relevant information from measurement config

1

### Summary `Workspace.build` does not propagate `auxdata` / `sigmas` from the measurement config to the new workspace. This is caused by the measurement config only taking into account a few...

Model hashing

5

### Summary It could be convenient to be able to hash a `pyhf.Model` to allow comparing models to each other. For an example, see @lhenkelm 's comment https://github.com/scikit-hep/cabinetry/issues/315#issuecomment-1023583140 and https://github.com/scikit-hep/cabinetry/pull/322,...

`lumi` modifier documentation and behavior

2

# Question The `lumi` modifier is described in the [documentation](https://pyhf.readthedocs.io/en/v0.6.2/likelihood.html#luminosity-lumi) with a reference to `\sigma_\lambda` and the [measurement section](https://pyhf.readthedocs.io/en/v0.6.2/likelihood.html#measurements) (I believe the link to that may be slightly broken, it...

Type of suggested bounds changes when specified in model config

4

### Summary The per-parameter bounds from `model.config.suggested_bounds()` are tuples by default, but become lists when specified in the specification via the model config section. For consistency, it would be useful...

### Summary Very minor point: the `init_pars` and `fixed_params` kwargs in the inference API like `pyhf.infer.mle.fit` are slightly inconsistent in their names ("pars" vs "params"). It might be nice to...

Documentation for parameter-related properties of `_ModelConfig`

1

### Summary There are a few different things available in a `model.config` for accessing parameters: - `model.config.parameters` for an alphabetically sorted, non-expanded (staterror/shaperror) list, - `model.config.par_order` for a non-expanded list...

Discovery significance calculation via CLI

1

### Summary For quick checks, discovery significance calculation via the CLI would be helpful to have. ### Additional Information There are (at least) two ways of going about this. The...

Make `model.config.par_names()` a property?

1

### Summary Currently [`model.config.par_names()`](https://github.com/scikit-hep/pyhf/blob/767ed59d06274f810e47944f1fe4c95d94968543/src/pyhf/pdf.py#L304-L329) takes no arguments and returns a list of parameter names. The behavior slightly differs from `model.config.channels` and `model.config.samples`, which are properties. For consistency, it may be...

Modifying parts of an existing model

2

# Question I noticed that it is possible to modify `config.channels` of an existing `Model`. That leads to some functionality taking into account the change, and other functionality breaking. It...