alexa-skills-kit-sdk-for-nodejs icon indicating copy to clipboard operation
alexa-skills-kit-sdk-for-nodejs copied to clipboard

feat(aws-sdk-s3-persistence-adapter, aws-sdk-dynamodb-persistence-adapter): upgrade dynamodb and s3 persistence adapters to use AWS SDK v3

Open sam-goodwin opened this issue 4 years ago • 5 comments

Closes https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/issues/697 Closes https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/issues/696

This change refactors the S3 and DynamoDB persistence adapters to use AWS SDK v3.

  • [ ] As this is a breaking change, I also bumped the major version of those libraries to 3.0.0. Is this correct or should it be a minor version bump?
  • [ ] Update the mocked unit tests. See https://www.npmjs.com/package/aws-sdk-client-mock

sam-goodwin avatar Oct 27 '21 01:10 sam-goodwin

Does this remove the dependency for the v2 AWS SDK fully, and make it fully v3 compatible?

paul-uz avatar Oct 27 '21 09:10 paul-uz

Yes, i removed it from s3 and dynamo db adapter packages.

sam-goodwin avatar Oct 27 '21 09:10 sam-goodwin

image

jheym avatar May 05 '23 20:05 jheym

Can we get this merged in yet? It's been 2 years...

paul-uz avatar May 08 '23 18:05 paul-uz

Can we get this merged in yet? It's been 2 years...

I no longer work at Amazon, sorry. Hopefully someone from the SDK team can help you out.

sam-goodwin avatar May 13 '23 02:05 sam-goodwin