alexa-utterances
alexa-utterances copied to clipboard
Added code to make slots optional
Added code to make slots optional by adding a "+" to the beginning and end of of desired slot name.
For example: {+OPTIONALSLOT+|}
You should write some tests and update README and CHANGELOG, please.
@dblock Perhaps it would be a good ideal to add a literal checklist to CONTRIBUTING? Or a issue template? Also there's no mention of updating the changelog in CONTRIBUTING
@dominicankev It looks like you used tabs instead of spaces for indenting your code. Please fix.
@mreinstein is the boss here, but I support this message, maybe you can PR it?
Hey guys. I apologize. Kind of new to the GitHub community and might have gotten a bit excited to post a commit. Should I cancel and update the files requested?
@dominicankev No worries! PRs are (in general) good to see. As for updating this PR see here.
@harrisonhjones Thanks! Will make the requested revisions. Thanks all!
Fixed space vs tab issues and trimmed test to reflect change instead of using existing.
Any idea if/when this PR will be merged?
@dominicankev thanks for taking the time to submit. Please submit a clean PR that includes tests.