alexa-utterances icon indicating copy to clipboard operation
alexa-utterances copied to clipboard

Added code to make slots optional

Open dominicankev opened this issue 8 years ago • 9 comments

Added code to make slots optional by adding a "+" to the beginning and end of of desired slot name.

For example: {+OPTIONALSLOT+|}

dominicankev avatar Jan 18 '17 14:01 dominicankev

You should write some tests and update README and CHANGELOG, please.

dblock avatar Jan 18 '17 16:01 dblock

@dblock Perhaps it would be a good ideal to add a literal checklist to CONTRIBUTING? Or a issue template? Also there's no mention of updating the changelog in CONTRIBUTING

@dominicankev It looks like you used tabs instead of spaces for indenting your code. Please fix.

harrisonhjones avatar Jan 18 '17 16:01 harrisonhjones

@mreinstein is the boss here, but I support this message, maybe you can PR it?

dblock avatar Jan 18 '17 17:01 dblock

Hey guys. I apologize. Kind of new to the GitHub community and might have gotten a bit excited to post a commit. Should I cancel and update the files requested?

dominicankev avatar Jan 18 '17 18:01 dominicankev

@dominicankev No worries! PRs are (in general) good to see. As for updating this PR see here.

harrisonhjones avatar Jan 18 '17 18:01 harrisonhjones

@harrisonhjones Thanks! Will make the requested revisions. Thanks all!

dominicankev avatar Jan 18 '17 21:01 dominicankev

Fixed space vs tab issues and trimmed test to reflect change instead of using existing.

dominicankev avatar Jan 19 '17 06:01 dominicankev

Any idea if/when this PR will be merged?

jradwan avatar Aug 20 '17 02:08 jradwan

@dominicankev thanks for taking the time to submit. Please submit a clean PR that includes tests.

mreinstein avatar Aug 20 '17 03:08 mreinstein