react-native-skeleton-content icon indicating copy to clipboard operation
react-native-skeleton-content copied to clipboard

Published 20 hours ago • verified publisher icon alexZajac

Remove Redash and update Reanimated

Open khevamann opened this issue 2 years ago • 9 comments

As I stated in #76 there were issues with my last PR. I hadn't tested it besides running tests and build. My last PR is a safe fix that I have tested. This PR is my attempt to remove redash which is unnecessary now as well as add better reanimated support. I have not tested this yet as the project I am using react-native-skeleton-content is only a minimal example. So I would love a sample project or something to test this branch in more detail. I was a little unsure how to remove loop.

So I would consider this a work-in-progress until I have a little more time to fine tune it

khevamann avatar Sep 19 '22 16:09 khevamann

Hey @khevamann, I don't believe we should switch to yarn, or at least if you believe we should please open a new PR as this is not related to the revert. Ping me when it's green so that we can review it thoroughsly!

alexZajac avatar Sep 19 '22 18:09 alexZajac

@alexZajac Yes this PR is not related to the revert. The other PR is what should currently be merged. This PR is me trying to get reanimated working with the updated version. However I probably won't get around to finishing this until next weekend. Yarn was me trying to test the fix because there was a bug that was apparently npm only. Switching to yarn didn't fix it though, so I will go back to npm. And yes I will ping you when this is ready for review after I find time to test it out

khevamann avatar Sep 19 '22 23:09 khevamann

@khevamann Hm... The highlight isn't working for me. Is it working for you?

yepMad avatar Nov 25 '22 04:11 yepMad

@yepMad No, this PR is not completed. I ended up switching to a custom implementation as I am not skilled enough with reanimated to replace all the existing functionality here.

khevamann avatar Nov 26 '22 16:11 khevamann

Hi! Any ETA or ways to unblock the PR on your side?

alexZajac avatar Dec 03 '22 15:12 alexZajac

Looking forward to this resolution -> Can't get my app running with this package currently. Expo at sdk 46

jakrim avatar Jan 15 '23 20:01 jakrim

Hi @khevamann, any progress?

alexZajac avatar Apr 01 '23 17:04 alexZajac

Hey guys! I would love to get this repo up to speed. How can I help getting this to reanimated v3?

Is this still planned?

wmonecke avatar Aug 15 '23 09:08 wmonecke

@alexZajac I have made it work with reanimated v3 and react-native-linear-gradient. I can add expo linear gradient package as well and a prop so it is possible to switch between the two if neccessary.

I gladly make a PR for you to review and approve so you can move away from reanimated v1 🚢 .

Alternatively, you can find the update here: https://www.npmjs.com/package/react-native-reanimated-skeleton

marcuzgabriel avatar Sep 06 '23 16:09 marcuzgabriel