react-native-skeleton-content icon indicating copy to clipboard operation
react-native-skeleton-content copied to clipboard

Expo SDK 45

Open zsomborgellerfi opened this issue 2 years ago • 5 comments

Describe the bug This package throws an error when using with Expo SDK 45.

To Reproduce Steps to reproduce the behavior:

  1. Import package in a project using Expo SDK 45
  2. Render component
  3. See error

Expected behavior This should be compatible with Expo SDK 45.

Error Error: Requiring module "node_modules/react-native-skeleton-content/lib/index.js", which threw an exception: TypeError: undefined is not an object (evaluating 'NativeUnimoduleProxy.viewManagersNames.includes')

Smartphone (please complete the following information):

  • Device: Iphone 12
  • OS: iOS 14
  • Package version 1.0.24

zsomborgellerfi avatar May 11 '22 09:05 zsomborgellerfi

You can use this https://www.npmjs.com/package/@03balogun/react-native-skeleton-content pending the time the issue is resolved.

03balogun avatar May 14 '22 21:05 03balogun

Same issue

alexanderwassbjer avatar Jun 14 '22 14:06 alexanderwassbjer

should we still use the forked @03balogun/react-native-skeleton-content for now, or there is a fix for the official version?

appsgenie avatar Aug 07 '22 03:08 appsgenie

@appsgenie I ended up using react-native-skeleton-content-nonexpo. That I got to work!

alexanderwassbjer avatar Aug 08 '22 10:08 alexanderwassbjer

@appsgenie I ended up using react-native-skeleton-content-nonexpo. That I got to work!

oh thanks @alexanderwassbjer, that's an official version being maintained? don't see as many commits to it so wondering if it's good for long-term

appsgenie avatar Aug 08 '22 15:08 appsgenie

use this skeleton and thnx me... npm i react-native-loading-placeholder

asadbjs avatar Aug 23 '22 09:08 asadbjs

@03balogun could you write a PR to update this package? I can't reproduce your code changes so that it works with Expo 45!

alexZajac avatar Sep 05 '22 23:09 alexZajac