Alex Killing

Results 40 comments of Alex Killing

We understand the requirement to have the tree available in the setup, but we close this PR. The major issue are the many workarounds in the initEnvironment function. E.g. the...

``` if (!$this->getMembersObject()->deleteParticipants($participants)) { ilUtil::sendFailure($this->lng->txt($this->getParentObject()->getType() . '_at_least_one_admin'), true); ``` The returned "false" should not represent this particular issue imo. Final course/group deletion might be a process that needs deletion of...

Hi @nmatuschek Thanks for providing a PR for this issue. Please answer the following questions: - [x] Why having a whole new class to tackle this, couldn't we just add...

I did not introduce these plugins and thus would not support them in 2,3,6.

@mjansenDatabay Yes, I know, but we are selecting from obj_members before anyway. So we could provide these or null values. If we use INSERT... ON DUPLICATE... shouldn't the SELECTS and...

@mdezi Thanks for the PR. Could you please provide a bug report according to the mentioned guidelines. Thanks.

Thanks, this should be fixed in the meantime.

@lscharmer Thanks for this PR. This is definitely needed. I would strongly suggest to extend the readme file https://github.com/ILIAS-eLearning/ILIAS/blob/trunk/components/ILIAS/Refinery/README.md with this PR, too, since this is what most devs will...