react-leaflet-draw icon indicating copy to clipboard operation
react-leaflet-draw copied to clipboard

Missing changelog

Open ThiefMaster opened this issue 3 years ago • 5 comments

I can't find it in any of the usual places (github releases, readme, tag descriptions).

Not having a changelog is really annoying when updating dependencies, especially when things break (e.g. #100)

ThiefMaster avatar Apr 13 '21 14:04 ThiefMaster

Git tags for the 0.19.x versions are missing as well...

ThiefMaster avatar Apr 13 '21 15:04 ThiefMaster

Git tags for the 0.19.x versions are missing as well...

@ThiefMaster What should be done in this case ? #90 was my first PR I did not know there is such a thing as change log.

DVGY avatar Apr 16 '21 18:04 DVGY

I would say this is something for the maintainer to do, but generally, an update to a new major version of a peer dependency like this one should also result in a major update of the package itself (so during 0.x a bump to 0.20).

Also, I just noticed that the peer dep is still "react-leaflet": "^2.0.0" and only the dev dep has been bumped to "react-leaflet": "^3.0.0"..

ThiefMaster avatar Apr 16 '21 18:04 ThiefMaster

@ThiefMaster I will work on it.

DVGY avatar Apr 16 '21 18:04 DVGY

@ThiefMaster So is this issue solved? Can I install react-leaflet-draw while my react-leaflet is ^3.0.0 ? Thanks!

GraceeFlower avatar Mar 16 '22 03:03 GraceeFlower