gymbox-bot icon indicating copy to clipboard operation
gymbox-bot copied to clipboard

Published 20 hours ago • verified publisher icon alex3165

updated the scheduler to only book classes for the day after it is run.

Open tmerlet opened this issue 5 years ago • 5 comments

fix for https://github.com/alex3165/gymbox-bot/issues/7

  • when running the scheduler, classes are only booked for the following day

I've left the CLI as is. Might simplify the code a bit if we just book classes for 'tomorrow' with both the cli and the scheduler.

tmerlet avatar Sep 09 '19 19:09 tmerlet

open to suggestions on how to improve it 👍

tmerlet avatar Sep 09 '19 19:09 tmerlet

Hey Alex, any thoughts on this pull request? :)

tmerlet avatar Oct 20 '19 19:10 tmerlet

Hey @tmerlet sorry for the late reply, I think we could remove all the other logic in the else statement. Only checking if the class is tomorrow is good enough in this filter. Would you mind updating it? Ideally if we could have some unit test to cover this that would be optimal but this is only optional if you have some time. Thanks for your work.

alex3165 avatar Oct 22 '19 16:10 alex3165

Hey @alex3165 :) I agree, it makes more sense to simplify and only have booking working for classes tomorrow only. Will give unit tests a go too.

tmerlet avatar Oct 25 '19 14:10 tmerlet

Need more time on this...

tmerlet avatar Nov 03 '19 22:11 tmerlet