Alex Gaynor comments

Results 909 comments of


                                            Alex Gaynor

Add eq to HashAlgorithm and padding instances

``` >>> {}.__eq__(0) NotImplemented ``` :-)

Cryptography parsed the CRL file with an empty Key Identifier.

Hmm, so an empty AKI is stupid, but it's not clear it violates the RFC? ``` AuthorityKeyIdentifier ::= SEQUENCE { keyIdentifier [0] KeyIdentifier OPTIONAL, authorityCertIssuer [1] GeneralNames OPTIONAL, authorityCertSerialNumber [2]...

Cryptography parsed the CRL file with an empty Key Identifier.

I'm not sure that it does.

Cryptography parsed the CRL file with an empty Key Identifier.

I think that's a good summary, the fact that they use the ALL CAPS MAY means that MAY carries this definition: ``` MAY This word, or the adjective "OPTIONAL", mean...

rt: improve spawn_blocking scalability with sharded queue

(FreeBSD failures look unrelated.)

Issue tracker migration

I don't know if this is related to the migration or not, but automation keeps updating the Reported dates on issues in nonsensical ways. For example: https://issues.oss-fuzz.com/issues/42477631

Comparing enums by identity

Where did we leave this? Is it just a matter of generating a better `IntoPy` for simple enums?

Metaissue: 3.15 support

https://github.com/python/cpython/commit/32b2c5de16183c74e43da01c5b33343e43c469a4 I think there might be an ABI change in PyModuleDef_HEAD_INIT?

Add methods related to client hello callback

Hmm, we should probably adapt the coverage bits to merge from multiple jobs (as we do on cryptography). @mhils do you have an opinion on this API?

Remove BER in PKCS#7 and PKCS#12

@eidorb thank you for reporting this, is there a PKCS#7 structure that you can share publicly with us, or do they contain PII? Are you able to report this to...