Alex Gaynor

Results 909 comments of Alex Gaynor

For your first rust code, it's right on the money :-) I could have sworn I had a PR somewhere that did this, and then we didn't merge it for...

Do we need an API for that? Callers can always just `s[:72]` themselves. On Fri, Feb 7, 2025 at 6:20 PM Paul Kehrer ***@***.***> wrote: > > I don't recall...

resolved in https://github.com/pyca/bcrypt/pull/1000

It's weird that `generate_key` is in the error, since you're obviously just parsing. I assume this is a consequence of the change in how we parse private keys, but I...

Ahh, because `DH_generate_key` is the API used to recompute the public key as part of key loading... this is so dumb.

Hmm, but the relevant OpenSSL code path also appears to call `DH_generate_key`.

Thanks for working on this! I haven't had a chance to look in depth, but re: PKCS7Unpadder, it'd be great to have that in a stand-alone PR.

We're always happy to have smaller PRs split out (though it can sometimes be complicated due to coverage). I'm hoping to have time to review this today, though it might...

@facutuesca FYI, if you're interested

Sorry I got behind, will have a look now. Thanks for your patience!