Alex Gaynor

Results 324 comments of Alex Gaynor

Maybe! I'm not sure. I'm also now many yaks deep and mostly turned my attention towards: https://github.com/nedbat/coveragepy/issues/1147

Awesome, didn't see it noted in the "future" section, so I figured I'd bring it up.

I believe that I wrote the Django version that this is based on. I can say definitely that the Django version is based on conversations (and maybe code?) I had...

I can say for sure that the version in Django is code that I wrote on teh flight back from DjangoCon, with @carljm, at Midway airport. Probably in 2011. I...

Would you accept a PR to `x25519_test.json` which marked any of the ones described as "public key with low order" as "Small public key"? Does the PR just get sent...

For what it's worth, the reason this is desired by us is that we use a different error type for bad `nonce` length than we do for other failures, since...

A question that came up for us: is `ecdsa_test.json` a concatention of all of the other `ecdsa_*_test.json` files, or does it contain it's own things?

Yeah, we'd love to kill pyOpenSSL, because the code is grody and sad-making and the APIs aren't very good. But it's still maintained and supported, so I don't have an...

FWIW, my opinion is that this patch opts for the straight forward and correct approach to solving this, I don't think closing this as a dupe of something last touched...

We did this on pyca/cryptography many years ago: https://github.com/pyca/cryptography/issues/1209 is how we did it.