glicky icon indicating copy to clipboard operation
glicky copied to clipboard

GUI crashes when terminal drop-down is expanded (Gnome Web Browser)

Open neutrino2211 opened this issue 5 years ago • 7 comments

Here is a side-by-side comparison between Google chrome and the Gnome Web Browser. Unfortunately, the page crashes before anything is logged to the console.

ezgif com-video-to-gif(1)

This seems to only bother the default gnome browser but we can't be sure, maybe we should test other browsers and make a compatibility list.

Continued from #4

neutrino2211 avatar Apr 22 '19 20:04 neutrino2211

and make a compatibility list

Love the idea of this, do you have any ideas about where we could keep such a list? I suppose it would be like an 'ongoing issue' but it would be good to keep it somewhere outside of a Github issues so that we can use issues for fixing the listed compatibility problems.

alex-saunders avatar Apr 22 '19 22:04 alex-saunders

As far as the actual issue here, I'm not sure how I'm going to best debug this as I don't have access to a Linux machine or Gnome web browser.. will think about the best approach.. @neutrino2211 would you be up for doing some debugging on this?

alex-saunders avatar Apr 22 '19 22:04 alex-saunders

and make a compatibility list

Love the idea of this, do you have any ideas about where we could keep such a list? I suppose it would be like an 'ongoing issue' but it would be good to keep it somewhere outside of a Github issues so that we can use issues for fixing the listed compatibility problems.

Yeah, maybe like a branch where we would add supported browsers to the README

neutrino2211 avatar Apr 22 '19 22:04 neutrino2211

And for the GUI issue, I will gladly take a look.

neutrino2211 avatar Apr 22 '19 22:04 neutrino2211

Hmm yeh I'm thinking maybe a branch where we have a compatibility.md file that gets updated as we tests browsers might be good.. will think a little more on it before committing to anything though.

alex-saunders avatar Apr 23 '19 13:04 alex-saunders

After numerous attempts, there is finally an error log

Screenshot from 2019-04-24 22 10 00

The browser never logged any errors till today but before that I placed console.logs in places where I thought an error would occur and more times than not it crashed right around XTermRenderer.createTextInstance

neutrino2211 avatar Apr 24 '19 21:04 neutrino2211

Yeesh that does not look like a fun error. Have had you had any luck finding the root cause of this @neutrino2211 ? It looks like the custom renderer is failing somewhere within the react internals? This could make it really tricky to debug (even harder because I can't access the Gnome browser).

Maybe here would be a good place to start delving around.

alex-saunders avatar Apr 25 '19 18:04 alex-saunders