Alex Oleshkevich
Alex Oleshkevich
Reusing Starlette `URL` class is a no-brainer here, IMO. This makes URL construction a breeze and have no limits: ```python url_for('welcome').include_query_params(greet=1) url_for('welcome').q(greet=1) ``` ```html welcome welcome ``` This is also...
I don't think the route class needs a new argument. The decorator itself has to manage request. So the decorator will return class based endpoint (an ASGI app) and will...
After thinking a lot, I agree that `append_query_params` is a nice add-on that comes along with the rest of methods of the URL class.
I think it is there just to stop the iteration as it is the only way to do it, afaik.
I can confirm that the issue does not exists when you run using `loop.run_forever()`. But it always happens when using `asyncio.run`.
Here is my config file: ```js const path = require('path'); const ENV = process.env.NODE_ENV || 'development'; const { WebpackManifestPlugin } = require('webpack-manifest-plugin'); const DEVSERVER_URL = process.env.DEVSERVER_URL || 'http://127.0.0.1:8080'; const assetsDir...
Leading underscores are less discoverable. When you type `n` IDEs suggest you `name` parameter. When the parameter starts with `_` then the autocompleting list if empty or not helpful. What...
There is no difference between `__name` or `name_`. But from DX perspective `name_` is more clear.
I use this approach quite a long time and the one downside I have is that I have to call `str(request.url)` when I need to pass current URL in headers...
I haven't found anything better than this yet. https://github.com/alex-oleshkevich/ohmyadmin/blob/master/ohmyadmin/ordering.py#L78