Alexander Courtis

Thanks @0x0013 that's really helpful. It seems that we are done with the catastrophic way-displays failures now, just the bad states remain. I will pursue this from the sway side...

Still working on this. I've experienced some reproducible errors when plugging / unplugging a dock with two displays.

A successful mode change implies enabled. Set it.

The serial does not increment on successful NOP. Perhaps something might be done with that.

Upon cancellation e.g. unplug dock a new serial is immediately sent but no further events. Changes may thus be retried immediately.

Practical solution: settle time (configurable, maybe 500ms default) between last wlr_output_management event and layout. May resolve #33 #36

This is a sway problem. `swaymsg -t command output DP-3 mode 3840x2160@24Hz` results in the same. [sway.1.acourtis.smc.log](https://github.com/alex-courtis/way-displays/files/8551981/sway.1.acourtis.smc.log)

When falling back after the initial unsuccessful modeset, [output_create_swapchain](https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/master/types/output/render.c#L76) sets the format to `DRM_FORMAT_MOD_INVALID` which appears incorrect. Setting to `DRM_FORMAT_MOD_NONE` resolves the issue. Documented workaround: https://github.com/alex-courtis/way-displays#known-issues-with-workarounds

Raised at wlroots: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3431

way-displays cannot rotate displays itself, although it does work when displays are rotated. Adding this as a feature request. Currently you can rotate using sway via its config e.g. `output...