alex-brinkman

I'd like to perform some refactoring to achieve the following aims: * Developers who add new device driver don't need to write any manager class code or YAML parsing code...

See the goals of this MR are contained in issue https://github.com/nasa-jpl/fastcat/issues/96 > Formalize device configuration with a std::variant typedef'ed to DeviceConfig to permit querying the device in programmatic manner through...

I do not think the below assignments are necessary. When the Fastcat manager calls its `Process` function, the state from the underlying JSD device will be read first, so `jsd_egd_state_`...

Add CONTRIBUTING.md

2

It would be a great help if you could help share your lessons learned with other developers on how to write JSD drivers. I suggest a `CONTRIBUTING.md` in the root...

SDO Thread refactor

1

I spent some time looking and thinking about this function and, although this works, I think we are overburdening the SDO thread with error handling. I think it would be...

I think we should make the pointer constant. It is pointing to a variable in SOEM. _Originally posted by @d-loret in https://github.com/nasa-jpl/jsd/pull/46#discussion_r1003888101_

I do not think NULL should be used as an indication of an empty queue. There are only two possible outcomes of this function and they are already handled by...

make it work like the newly added `jsd_error_cirq` functions

Found some old TODOs in code to check the state feedback on drives with hall-effect sensors. Would be good to indicate that works so we're not caught off-guard in the...