useWorker
useWorker copied to clipboard
Fix kill functionality
Fix for the issue reported with the kill functionality reported in the below issues:
- https://github.com/alewin/useWorker/issues/119
- https://github.com/alewin/useWorker/issues/118
- https://github.com/alewin/useWorker/issues/115
@alewin @zant please review
Porque aun no esta este fix :(
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
Also looking for review and merge, implementing @ashish-r's changes through patch-package
for now.
In Firefox not updating of the state blocked the whole thread as the following try couldn't continue (recognizing the previous worker process as still running).
The patch-package
file to be found here: https://gist.github.com/optimista/69e168b9eb63921ce188ef555c709f4d
Thanks @ashish-r Please forgive my long absence 🙏 , I'm back :)
cc: @optimista @TianJianJun727 @federicoWax @LorhanSohaky @zant
Hey @alewin thanks for merging the PR. I see that the release workflow failed in the Setup pnpm config
. Do we manually release the package? Or should I check the workflow failure and patch the same?
PS: We need to upgrade the node version here: https://github.com/alewin/useWorker/blob/master/.github/workflows/release.yml
@ashish-r Are the above fixes deployed?
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
Hi @alewin, thanks for merging the PR, the fix is not yet released. Please let me know if there is anything else you need.
I wasted hours setting my code up for this lib, and now I discover I can't kill workers. It makes things completely useless for me.
For anyone else who wants to get a quick solution from this, use https://github.com/Shopify/quilt/blob/main/packages/react-web-worker/README.md
. Much more stable and feature-complete.