useWorker icon indicating copy to clipboard operation
useWorker copied to clipboard

Update to react 17

Open MatanYemini opened this issue 3 years ago • 8 comments

I don't think that description is needed.

I don't mind to do, just update me if you allow.

Thanks.

MatanYemini avatar Jan 22 '22 19:01 MatanYemini

What do you think needs updating? AFAIK this is still compatible with React 17.

cgarrovillo avatar Mar 01 '22 17:03 cgarrovillo

I believe I've run into the same issue here. As suggested in the error message, it does work fine with --legacy-peer-deps, so it's not critical.

Steps to reproduce: run npm install --save @koale/useworker in a project which uses React 17.0.2 Expected result: package installs Actual result: receive the following error: npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: [email protected] npm ERR! node_modules/react npm ERR! react@"^17.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.0" from @koale/[email protected] npm ERR! node_modules/@koale/useworker npm ERR! @koale/useworker@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /home/cassm/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in: npm ERR! /home/cassm/.npm/_logs/2022-03-09T12_41_04_040Z-debug-0.log

The mentioned log files are attached. eresolve-report.txt 2022-03-09T12_41_04_040Z-debug-0.log

cassm avatar Mar 09 '22 12:03 cassm

Same issue with react 18:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @koale/[email protected]
npm ERR! node_modules/@koale/useworker
npm ERR!   @koale/useworker@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/vittorio/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/vittorio/.npm/_logs/2022-04-09T14_41_58_833Z-debug-0.log

however using --legacy-peer-deps seems to workaround the problem

VittorioAccomazzi avatar Apr 09 '22 14:04 VittorioAccomazzi

I have the same issue and I cant fix with --legacy-peer-deps

jonbeacherdomuso avatar Nov 10 '22 03:11 jonbeacherdomuso

I will fix this in the next release, thanks!

alewin avatar Dec 11 '22 13:12 alewin

Any timeline on the next release?

atrakh avatar Mar 03 '23 23:03 atrakh

Any update on this @alewin ? :)

yezzer avatar Mar 23 '23 16:03 yezzer

When will be the next release @alewin? :)

I will fix this in the next release, thanks!

Mariam-maghraby avatar Nov 08 '23 12:11 Mariam-maghraby