useWorker icon indicating copy to clipboard operation
useWorker copied to clipboard

Fix issues with isoworker

Open 101arrowz opened this issue 3 years ago • 1 comments

I'm not sure what tooling to install to test this locally, so I'm just creating this PR to show the most appropriate usage of isoworker. I don't know how to set up Karma with Mocha, but the build looks fine after bundling, and if it fails that's fixable via https://github.com/reactioncommerce/reaction-component-library/issues/399#issuecomment-467860022.

As a side note, you may want to consider hiding isoworker behind a feature flag that adds local dependency support, since that will reduce bundle size by quite a bit. isoworker, in the name of supporting everything that could possibly need to be serialized, adds around 3kB gzipped to the overall bundle size.

101arrowz avatar Mar 21 '21 20:03 101arrowz

thanks @101arrowz! as soon as I find some free time, I'll check and test the pr

alewin avatar Mar 22 '21 19:03 alewin