Alejandro Torrado comments

Results 27 comments of


                                            Alejandro Torrado

Polymer 3 and Web Components

Any update about this feature?

Added support for HLS title and artist metadata

Hi Ryan, I just sync'd this pull request with the latest commits from minor. Could you please revisit this pull request and consider merging it? Thank you!

TypeError: observerHandle is null in Firefox

+1 !!!

TypeError: observerHandle is null in Firefox

Any update on this?

ShadowDOM support

Any update about this feature?

Suggestion: allow to discard original syntax `@media (prefers-color-scheme: dark)`

It would be the same output with the parts wrapped in the media queries stripped. Like this: ```less /* Input CSS */ @media (prefers-color-scheme: dark) { html { --text-color: white...

Suggestion: allow to discard original syntax `@media (prefers-color-scheme: dark)`

Just keeping the output small, with the drawback that will require JS code to initialize the classList (just like it's also needed to avoid FART). It's pretty common in postcss...

Suggestion: allow to discard original syntax `@media (prefers-color-scheme: dark)`

I don't think it's a better option. I think there are drawbacks in both options, and having duplicated code may be a bigger drawback in some cases. I don't think...

Suggestion: allow to discard original syntax `@media (prefers-color-scheme: dark)`

Thanks for merging #34 Continuing the discussion, I don't think there will be any FART at all if you have the JS snippet embedded into the HTML code, or loaded...

Suggestion: use `:not(.is-dark)` as lightSelector by default

You're totally correct. This only makes sense with the `preserve: false` functionality that I proposed. Thanks