desktop-wallet icon indicating copy to clipboard operation
desktop-wallet copied to clipboard

Implement combined addresses+contacts selection modal

Open nop33 opened this issue 2 years ago • 5 comments

nop33 avatar Mar 08 '23 14:03 nop33

Transfering our discussion from Figma:

@nop33 wrote:

It's a beautiful design! I am not so sure about it's usability though. Hear me out: We use the address selector in these places:

  1. Send modal (from address)
  2. Deploy contract modal (from address)
  3. Call Script modal (from address)
  4. WalletConnect modal (signer address)
  5. Sweep address modal (1. from address, 2. to address)
  6. Receive modal (select address to receive funds to)

In addition to those, we have 1 extra input field for selecting a contact (Send modal - to address). In 1, 2, 3, 4, and 5.1 we don't want the user to select an address that they don't own, so the "Contacts" tab would not be useful. In 5.2 and 6 it COULD be useful, but it doesn't align really with the context of each. Do we want to promote the feature of "sweep funds from one of your addresses to a contact"? If so then ok! This is still currently possible if the user just copies the contact address, more clicks though.
As for the "Receive" modal, even though it'd be useful to see the QR code of a contact, I don't think it's the right place (you're not gonna "receive" anything, might be confusing). Better just add a feature of displaying a QR code in the Contacts page (which is not rly needed until our mobile wallet is out).

I believe our current address selector and contact selector are sufficient and they work well! I'm happy to work on this if you think it's important, but let's first clarify my comments above. But I think it's more important to work on WC deep linking, analytics, testing and refining.

@mvaivre wrote:

Woah, such a detailed answer :D I meant to use this only in the "send modal" when I designed it. But we could also have one component with props letting us choose if we want to :

  • Only let the user select one of its own address (no tabs)
  • Only let the user select one of its contact (no tabs)
  • Let the user select both: in that case we display tabs.

nop33 avatar Apr 12 '23 11:04 nop33

@mvaivre I still cannot see the usability of this component and I wonder if you could help me see it. If you think it's important to work on for this release I'll work on it. Currently, this is what we have:

Address selector

Image

Contact selector

Image


I think both of those are perfect for the v2.0 release 🌼

nop33 avatar Apr 12 '23 11:04 nop33

@JKtranslator suggested that:

Suggestion: Add your own addresses automatically to the "contact list". It is way more convenient to get it from there than remembering that you need first copy the address you want to send to and then go to the address you want to send from and hit the send button image

Having a selector modal for both your own addresses as well as contacts would help here! Let's plan this for the next release.

nop33 avatar May 04 '23 08:05 nop33

@VDAODAO wished for the same feature!

nop33 avatar May 04 '23 08:05 nop33

@mvaivre, if I am not mistake, this is already part of your work to improve the send workflow, correct? Feel free to close/transfer this issue.

nop33 avatar Nov 16 '23 08:11 nop33