aleph icon indicating copy to clipboard operation
aleph copied to clipboard

Add "Add to..." button to entity preview

Open adryd325 opened this issue 2 years ago • 6 comments

Perhaps the "Add to..." button should be seperated into its own component

adryd325 avatar Aug 18 '23 02:08 adryd325

Hi @adryd325, thanks a lot for opening your first PR in this repository. I think adding this button to the entity preview is a good idea, but I will need to take a closer look which will unfortunately take some time. Sorry about that! :)

tillprochaska avatar Aug 23 '23 09:08 tillprochaska

@adryd325 Just to let you know we've not forgotten about this issue.

Rosencrantz avatar Sep 28 '23 09:09 Rosencrantz

@adryd325 Just something we noticed. You've branched from our main branch. Can you update this work to come from the develop branch instead? If you check our dev guidelines you'll see that all new work needs to be branched from the develop branch: https://github.com/alephdata/aleph/blob/develop/CONTRIBUTING.md#branches

Rosencrantz avatar Sep 28 '23 09:09 Rosencrantz

Let me know if you’d like to extract the button into a separate component yourself. Otherwise, I can also take care of that before merging :)

I'll take a look at that now

Can you update this work to come from the develop branch instead?

I've changed the base to develop and caused a mess, i'll try fix that up or re-create the PR against develop

adryd325 avatar Oct 16 '23 18:10 adryd325

I've managed to move the branch over to develop, and I've moved the Add to button to its own element, I've not had the chance to test yet.

I also should probably make the count element only show up when needed

adryd325 avatar Oct 16 '23 19:10 adryd325

@adryd325 Cool, thanks a lot. Just ping me when you’ve had a chance to test it and I’ll take another look!

tillprochaska avatar Oct 16 '23 19:10 tillprochaska