aleph-vm icon indicating copy to clipboard operation
aleph-vm copied to clipboard

Provide a template for new PRs

Open olethanh opened this issue 1 year ago • 3 comments

As discussed, providing these informations on each PR should improve review and code quality

olethanh avatar Aug 14 '24 09:08 olethanh

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.46%. Comparing base (902cf85) to head (f065a3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          68       68           
  Lines        5986     5986           
  Branches      633      633           
=======================================
  Hits         3679     3679           
  Misses       2152     2152           
  Partials      155      155           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 14 '24 10:08 codecov[bot]

What about reusing the template from https://github.com/aleph-im/aleph-client/pull/244/files instead of the generic one ?

hoh avatar Aug 19 '24 08:08 hoh

It's not generic, I Just opened all the Pr at the same time. Will update this one.

olethanh avatar Aug 20 '24 07:08 olethanh

Is there any reason not to merge this one?

Psycojoker avatar Aug 27 '24 16:08 Psycojoker

I restarted the test that failed.

hoh avatar Aug 28 '24 07:08 hoh