aleph-vm
aleph-vm copied to clipboard
Feature: allow IPv6 DNS
Problem IPv6 DNS were automatically filtered when detected from resolvectl
Solution: Nameservers are now split into ipv4 and ipv6 and can be passed to the VM accordingly At the moment we pass them if the ipv6 parameter is present on the tap interface but we need a more robust detection method.
This is an alternative implementation of #378. As @odesenfans said in the other thread ideally , we should have the supervisor and runtime communicate to us if they support ipv6 and then only pass the ipv6 nameservers not sure if someone know a way to do that or if it's a new spec we should come up with? Also don't know if it's a blocker
This needs to be rebased on top of the current main branch.
Codecov Report
Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.
Project coverage is 62.58%. Comparing base (
089ccef) to head (c5f09cf). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/aleph/vm/conf.py | 58.82% | 3 Missing and 4 partials :warning: |
| src/aleph/vm/controllers/firecracker/instance.py | 60.00% | 0 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 62.64% 62.58% -0.06%
==========================================
Files 69 69
Lines 6131 6140 +9
Branches 490 496 +6
==========================================
+ Hits 3841 3843 +2
- Misses 2146 2147 +1
- Partials 144 150 +6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.