Andrew
Andrew
IMO we should integrate v2 f/e with curve (and probably uniswap for eth/wbtc) to allow arbitrary swaps via a callee. Ie buy your ETH options in USDT, DAI, USDC, ETH,...
CompoundPricer requires that ChainlinkPricer's dispute period is over and the price is finalized before running and calculating the cToken exchange rate in USD or requires that the dispute period for...
In rebalanceVaultNft, GeneralSwap action is exactIn only, is exactOut swap better at times/needed?
Right now, only exactIn swaps are supported, are there case where we want/need an exact out swap? @alpinechicken can you think about this? @KMKoushik , for the front end is...
Should have a PR to update natspec, improve comments, check that they are all correct
We hardcode in the assets swapped so only allow trading on oSQTH/ETH pools for now.
**Please describe the problem you're having.** New ControllerHelper contract - should have Mint + LP test that checks refund ETH is working correctly and correct refund sent to user **Additional...
Look at reentrancy and confirm that covered by reentrancy in Controller or needs to be added
Tests for controller helper should all test with slippage included. This pattern ensures that we test the refund/burn/etc of excess eth/weth/oSQTH. It is also best to explicitly check if the...
**Describe the bug** Prevent frontrunning mev attacks on initial deposits. Not an issue now, but should improve it for future iterations.