tree-sitter-make icon indicating copy to clipboard operation
tree-sitter-make copied to clipboard

Published 20 hours ago • verified publisher icon alemuller

Remove the TODO test

Open aryx opened this issue 1 year ago • 5 comments

This prevents to use this repository in other repository with automated testing because the tests currently fail.

test plan: npm test

aryx avatar Jun 21 '23 12:06 aryx

@alemuller we would like to use your tree-sitter-make in semgrep, so people can write Semgrep rules to find errors in Makefiles, but those failing tests are annoying for our release process. Would you mind merging this PR? This would help us a lot.

aryx avatar Jun 21 '23 12:06 aryx

This would help https://github.com/returntocorp/semgrep/issues/8087

aryx avatar Jun 21 '23 12:06 aryx

ping @alemuller

aryx avatar Jun 26 '23 08:06 aryx

@alemuller if you don't maintain this repo anymore, I'll fork it, but I'd rather avoid a fork if we can agree on merging this PR.

aryx avatar Jun 27 '23 13:06 aryx

Ok I'll fork your repo then @alemuller . A bit sad. I would have rather avoided it.

aryx avatar Jul 18 '23 16:07 aryx