litematica-printer icon indicating copy to clipboard operation
litematica-printer copied to clipboard

Published 20 hours ago • verified publisher icon aleksilassila

Faster printing.

Open JackDainzh opened this issue 1 year ago • 4 comments

This is the initial pull-request for the faster version. Tested it only on 1.19 and haven't tested it out on 1.19.2 as I didn't have a need for that. Feel free to modify it and test it, I think it should work the same.

JackDainzh avatar Aug 15 '22 16:08 JackDainzh

is it possible to merge please? @aleksilassila

momokinou avatar Sep 28 '22 17:09 momokinou

is it possible to merge please? @aleksilassila

Right sorry, I'll make some reviews, if you could solve first

aleksilassila avatar Sep 28 '22 17:09 aleksilassila

@JackDainzh :D

momokinou avatar Sep 30 '22 07:09 momokinou

ah, sorry, for now I am not so keen on resolving stuff, I just did the base, not to familiar with github and versions codes in general. If I have free time someday, I might pull this off tho. To add: what do you mean by the "same line endings"?

JackDainzh avatar Sep 30 '22 09:09 JackDainzh

I included your solution in the printer rewrite I'm currently doing, thank you for your solution. Gonna merge by hand since the files changed so drastically.

aleksilassila avatar Dec 04 '22 13:12 aleksilassila