gitflow-maven-plugin icon indicating copy to clipboard operation
gitflow-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon aleksandr-m

Pull request on feature branch because of needed review

Open baedorf opened this issue 1 year ago • 5 comments

Normally, I would implement a feature and a colleage should review the implementation before merging the feature into develop. After finishing the review, the plugin should be executed to merge feature into develop. Is this possible?

baedorf avatar Jun 02 '23 05:06 baedorf

@baedorf What exactly? What do you want plugin to do?

aleksandr-m avatar Jun 12 '23 12:06 aleksandr-m

I don't know if its part of gitflow strategy, perhaps I need an additional goal like feature-review. This should create a pull request. Within this pull request, a code reviews can be performed. After review is finished (organizational task), feature-finish should merge pull request and update dependencies/versions like in actual implementation.

baedorf avatar Jun 12 '23 12:06 baedorf

Pull request where? For example when using gitlab, merge requests can be created using git push options. See readme to configure this in plugin.

aleksandr-m avatar Jun 12 '23 13:06 aleksandr-m

I need the for github and can't find push options as linked in gitlab. Could you please provide an example on how to perform this with yout plugin?

baedorf avatar Jun 13 '23 04:06 baedorf

AFAIK GitHub doesn't provide means of automatically creating PR-s from commits.

aleksandr-m avatar Jun 13 '23 10:06 aleksandr-m