gitflow-maven-plugin icon indicating copy to clipboard operation
gitflow-maven-plugin copied to clipboard

Adds release-finish check for remotes

Open jam01 opened this issue 5 years ago • 4 comments

Adds remotes when checking that no other release branches exist. This is important when using in a CI server context where automated builds will only checkout a single branch when triggered.

Open to feedback :)

jam01 avatar Apr 11 '19 23:04 jam01

@jam01 Can you provide more information. Why do you care if there is a release branch somewhere? Why don't you use release branch to trigger CI builds?

And you need to fetch before checking remote in this way.

aleksandr-m avatar Apr 16 '19 19:04 aleksandr-m

Sure. We already have the release branch commit trigger the CI. The issue we're having is that some releases may still be done manually and may not use the plugin, possibly leaving a release branch open.

Sent from ProtonMail mobile

-------- Original Message -------- On Apr 16, 2019, 2:44 PM, Aleksandr Mashchenko wrote:

@jam01 Can you provide more information. Why do you care if there is a release branch somewhere? Why don't you use release branch to trigger CI builds?

And you need to fetch before checking remote in this way.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jam01 avatar Apr 16 '19 19:04 jam01

I think this would encourage devs to use the plugin since the CI would correctly stop misuse of the the branching strategy

Perhaps a similar check should be done for opening releases. A dev could open a release just to try to get some feature through UAT without checking that there was already another release ongoing.

jam01 avatar Apr 16 '19 20:04 jam01

Please help me on this.

[INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1.984 s [INFO] Finished at: 2020-04-24T17:46:01+05:30 [INFO] ------------------------------------------------------------------------ [ERROR] No plugin found for prefix 'gitflow' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (C:\Users\Shivansh.m2\repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/NoPluginFoundForPrefixException

C:\Users\Shivansh\Downloads\gitflow-maven-plugin-master\gitflow-maven-plugin-master>mvn -B gitflow:release-start gitflow:release-finish [INFO] Scanning for projects... [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml

bpnrd avatar Apr 24 '20 13:04 bpnrd