Alessio Buccino

Results 495 comments of Alessio Buccino

We should definitely at least add the image hash to the spike sorting log/params ASAP! Great point! For usage, I would tend to aboid additional complexities to the `run_sorter` function,...

I think it's not a mistake to pass `["templates", "random_spikes"]` as input, so I don't think that the techicality of what depends o what is so educational that should trigger...

> I've updated it so that `extensions` is not edited/updated. Thanks @h-mayorquin > > So the other issue comes down to whether `['waveforms', 'random_spikes']` is an error or not. This...

What about using `alias` instead of `name`? so we don't change the class attribute but we can still assign custom names to the objects. Also, what is the behavior when...

Let's move forward with this by: - use the `name` and dump it in the annotations - having setters/getters to interact with the annotation This will make sure that it's...

Ok @DradeAW will confirm tomorrow, but he told me he's not using `.name` in Lussac. So my proposal is to get rid of the `name` class atributes (also in all...

@samuelgarcia is ok with this! We discussed yesterday :)

@h-mayorquin @samuelgarcia after https://github.com/SpikeInterface/spikeinterface/pull/3153 and as discussed, I made a property `name` which is stored in the annotations. Making it a `_main_annotation` propagates them to dictionary and children by default....

I propose we remove the `channel_ids` argument and suggest to use `sparsity` instead

@samuelgarcia @DradeAW Fixed it. Basically, when you pass `channel_ids`, you force the sparsity to be the channel_ids you passed for all units. I think this is the intended behavior.