vscode-pascal-formatter icon indicating copy to clipboard operation
vscode-pascal-formatter copied to clipboard

[FEATURE] - Don't require quotes around paths with spaces in engineParameters setting

Open Merlin2001 opened this issue 1 year ago • 1 comments

I noticed when first setting up PascalFormatter that the engineParameters path needs to be enclosed in " while the enginePath setting does not (when the path contains a space).

So my settings file currently has to look like this:

// Path for `pascal.formatter.engineParameters` needs to be enclosed in quotes if it contains spaces!
"pascal.formatter.engineParameters": "\"C:\\Coding Guidelines\\DummyFormatter.config\"",
// No quotes allowed around `pascal.formatter.enginePath`!
"pascal.formatter.enginePath": "C:\\Coding Guidelines\\Formatter.exe",

It would be great if both paths could be entered consistently either with or without quotes (and I think I'd prefer the latter one by always enclosing the engineParameters in quotes so the user doesn't have to take care :))

What do you think?

(I might be able to pick this up while/after working on #51 )

Merlin2001 avatar Jul 10 '23 17:07 Merlin2001

Hi @Merlin2001 ,

First of all, sorry for the late reply. It has been a busy period and I ended up missing a few notifications.

About your request, sure, it could be made consistent for the end user. The code could take care of adding the necessary double quotes, when necessary.

Feel free to send a PR.

Thank you

alefragnani avatar Sep 28 '23 00:09 alefragnani