no-describe-selectors does not work for cucumber step_definitions

[jlin412]

Is there that we can support cucumber step_definitions as well for this rule?

[alecxe]

@jlin412 good idea. I was afraid I should not be sticking to jasmine/mocha framework style in the plugin that much. Do you think it would be better to generalize no-describe-selectors to also support cucumber, or create a separate rule (set of rules) specifically for cucumber?

Thanks!

[igniteram]

@alecxe I would suggest to have to separate set of rules as there many contrasting features between jasmine and cucumber . Let me see if could send some PR's!

[alecxe]

@igniteram would really appreciate it. Let me know if you need any help or any adjustments to the current rules or exposed settings to support the new cucumber rules. Thank you.

[alecxe]

@igniteram by the way, you can ping me on gitter whenever needed

[igniteram]

Sure @alecxe will do that 👍

[jlin412]

Just throw it out there that no-get-in-it https://github.com/alecxe/eslint-plugin-protractor/blob/master/docs/rules/no-get-in-it.md rule doesn't apply in cucumber step definition though it is not as critical as the other one. I am happy to help test if there is a PR.

On Fri, Aug 12, 2016 at 3:39 PM, Ram Pasala [email protected] wrote:

Sure @alecxe https://github.com/alecxe will do that 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alecxe/eslint-plugin-protractor/issues/49#issuecomment-239541086, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF6jZ0lHZ0kGODg5fzSSgCJdbJf8tg2ks5qfMvVgaJpZM4JjWAU .

[alecxe]

@jlin412 gotcha, please disable the rules that don't apply to your particular case.