chroma icon indicating copy to clipboard operation
chroma copied to clipboard

rrt style: Missing syntax highlighting for `.diff` files

Open fyrak1s opened this issue 3 years ago • 2 comments

Greetings,

I am using the theme rrt and I love it! But I've noticed that it does not syntax highlight .diff files at all.

Take this sample:

- foo
+ bar

And try it on https://swapoff.org/chroma/playground/.

It works perfectly with the monokai style, while rrt does not provide any highlighting. However other styles seem to be affected, too.

Thanks in advance, I hope it can be resolved. I did not seem to have any issues with rrt with other file formats and I do love the theme! :)

fyrak1s avatar Feb 07 '22 19:02 fyrak1s

Is there any color in particular you want? Otherwise I'll commit this:

<entry type="GenericDeleted" style="#f92672"/>
<entry type="GenericInserted" style="#a6e22e"/>

image

serhack avatar Nov 10 '22 21:11 serhack

Hi @serhack, Thank you for asking my opinion :) What do you think about:

<entry type="GenericDeleted" style="#f00"/>
<entry type="GenericInserted" style="#0f0"/>

and #87ceeb for the @@ and #ff0 for index and diff lines, like so:

rrt

I think it would suit the theme well. I reused other rrt colors, but they hopefully shouldn't collide here..

fyrak1s avatar Dec 11 '22 22:12 fyrak1s