Alec Ritson

Results 149 comments of Alec Ritson

I haven't had a chance today, will try and take a look in the next couple of days :)

~~Hey @adam-code-labx this still didn't seem to work for me...~~ ```php

@adam-code-labx Yeah sorry I didn't realise that Github Desktop didn't pull down the latest changes. The initial test I did does in fact call the the `dd`

@adam-code-labx Still I think the trait naming is off `HasExtendableModels` suggests it has multiple models that are extended associated to it. Can we just go with `HasModelExtending` for now? Aside...

@glennjacobs I think you're thinking of the old version. Doesn't look like it's on 2.0

> @alecritson Also we're not migrating existing data into the new format, meaning if someone was to upgrade and run the migrations as they are currently, they'd lose all their...

@adam-code-labx Are you finished up for now? So I can pull this down and give it a test ?

Also might be worth mentioning @adam-code-labx I've added some table tests, be good to get some in there that match.

@adam-code-labx Pulled down the branch and ran it on the demo store and it seemed to work well 🥳 good work! My only question, i'm sure @glennjacobs will have an...

Personally I'd hold off doing a PR with filament forms. It would be quite a big undertaking and I don't think we'll be looking to add it any time soon.