Aleksander Machniak

Results 86 comments of Aleksander Machniak

"Loaders" would make sense, we already have "Progress" for progress bar and it should stay separated. Please consider "pulse" or "wave" instead of "dots", in case replacing `` with ``...

I suppose BYTEA columns require a query parameter to be bound as `PDO::PARAM_LOB`.

There's an example of what I'm talking about in `Sabre\DAV\PropertyStorage\Backend\PDO::propPatch()`. The same would have to be done in `Sabre\CalDAV\Backend\PDO` and `Sabre\CardDAV\Backend\PDO` where calendardata and carddata columns are INSERTed/UPDATEd.

`Sabre\DAV\Server::getIfConditions()` implementation is very simple. It won't handle properly also `(Not ["etag1"] Not ["etag2"])`, nor `(["tag1"] Not )`, nor anything with more than two conditions. Spec: https://datatracker.ietf.org/doc/html/rfc4918#section-10.4.2

I believe it is fixed in master and it's dependencies.

It depends on the authentication backend. https://sabre.io/dav/authentication/

Documentation says: "Note that scalar values are converted to string internally before they are filtered".

You're right. However, null is converted to string anyway (there's convert_to_string() call in the code). So, the documentation should be fixed. this convert_to_string https://github.com/php/php-src/blob/0561783903054b038a01f9279e761dc5bc29c41a/Zend/zend_operators.c#L719

I see the second commit here is unrelated and should be removed. Also, it would be great to have a test added in tests/Sabre/DAV/Locks/PluginTest.php.

I was talking about this https://github.com/alecpl/sabre-dav/commit/7a549bc064e52ea7ea2616bd18af1e20b3b20a91 I must say that I have no clue if that does not break other clients. Seems all tests still work.