streaming_algorithms
streaming_algorithms copied to clipboard
alecmocatta
Added mem-dbg as optional feature
Mem-dbg is a crate that allows to compute the size of a struct. I have added the derives through the crate as an optional feature, so as to use it to compare this implementation with others easily.
Cheers!
FYI, the errors are caused by the CI configuration being old. Consider updating it.
Thanks for this! Let me know when done and will merge despite the outdated CI.
Hi @alecmocatta, sure - I am running some benchmarks so I may add some other small edits.
Why are you checking whether the estimates are three-sorted? I see that you run a binary search but that requires the estimates to be completely sorted, and I recently discovered that the estimates provided from the HLL++ paper are not sorted (they nearly are). I will be providing a fix for that shortly.
https://github.com/alecmocatta/streaming_algorithms/blob/99522db25ab4f7a7ba91c793b7568cc1c62afa56/src/distinct/consts.rs#L33-L45