Alec Gibson

Results 85 comments of Alec Gibson

The only reason I realised what was going on was a random comment attached to the [v16.1.2 release](https://github.com/vuejs/vue-loader/releases/tag/v16.1.2)

Another suggestion would be to add Vue3 to the `peerDependencies`.

The alternative to this pattern is let's say you have a singleton: ```typescript // foo.ts export default getModule(Foo, store); ``` ...which you call in your component: ```typescript import Foo from...

@souphuhn I've since changed away from this pattern. We're now adding the store singleton to the Vue prototype: ```javascript Vue.prototype.$foo = getModule(Foo, store); ``` ...which means that in the components,...

Shouldn't you have: ```javascript const myMockedFoo = { someData: 'mockedValue', }; ``` ? Pretty sure this would become obvious if you inspect the runtime value of `this.$foo` inside your component.

@dgroh it looks like you have a circular dependency here? You import `store` into `OverviewModule`, but `store` itself also has a dependency on `OverviewModule`. I suspect if you remove the...

Could you please provide a minimal working example?

I verify this solution. I've changed the whole block to look like this: ``` javascript if (isString(modelValue)) { viewValue = modelValue; } else if (isObject(modelValue)) { if (isString(modelValue.name)) { viewValue...

I think @ppena-LiveData 's [solution](https://github.com/pladaria/reconnecting-websocket/issues/165#issuecomment-1125512025) is the correct one. If you reset `_connectLock` in the `close()` method, you can wind up opening several WebSockets if you rapidly call `close()` and...

Also, since I've written them if anyone wants tests for the other cases discussed here: ```ts test('reconnect after max retries', done => { const ws = new ReconnectingWebSocket(URL, undefined, {...