Alexandre de Souza
Alexandre de Souza
Is this still in progress? Or you guys want help?
It's ready to review again cc @josevalim
I was thinking about the issue #119 and concepting the idea of an Adapter for the DB layer. As we can improve the access to database, with good indexes to...
I have been thinking about that some days ago, where we could serve the assets from Kino and other users could create their SmartCells with these assets from `kino`
> ```elixir > # config/config.exs > config :my_app, MyApp.Mailer, > adapter: Bamboo.MandrillAdapter, > interceptors: [{MyApp.Mailer.Interceptor, "staging"}] > ``` Follwing this example, i think we could have the `opts` paramater to...
Using your commit, we should still use `call_opts/2` instead of `call/2`? Using the optional callback is a good way to not ship breaking changes
Making both optional sounds good, but i don't think it would be a good interface. Because if someone is implementing the `Bamboo.Interceptor` behaviour, he should implement one of both options....
hi @germsvel. I liked ur second option for `deliver_later`, it would be awesome to track all async delivery, so we can log, trace and audit everything. I'm working in a...
@germsvel I liked it
A good implementation would extract the full html and test the element using [floki](https://github.com/philss/floki) and get the element by tags and assert if content has the token, right? @michelbieleveld