obsidian-camera
obsidian-camera copied to clipboard
Add second Load button for Mobile
Add a second button for mobile devices, making the first for capturing "Video" from the camera app and the second for capturing"Images". This resolves the issues open for Android devices that currently can't capture images.
Summary by Sourcery
Add a separate button for capturing images on mobile devices, alongside the existing video capture button
New Features:
- Introduce a second file upload button specifically for capturing images from the camera app on mobile devices
Bug Fixes:
- Resolve image capture limitations for Android devices by adding a dedicated image upload button
Enhancements:
- Modify the camera modal to support separate video and image capture buttons
- Improve mobile file upload interface with distinct buttons for video and image capture
Reviewer's Guide by Sourcery
This pull request adds a second 'Load' button for mobile devices to allow users to capture images directly from their camera app, addressing an issue where Android devices couldn't capture images. The existing button is now dedicated to capturing video.
Updated class diagram for CameraModal
classDiagram
class CameraModal {
+filePicker: HTMLInputElement
+filePicker2: HTMLInputElement
+label: HTMLLabelElement
+label2: HTMLLabelElement
+videoEl: HTMLVideoElement
+mediaRecorder: MediaRecorder
+chunks: BlobPart[]
+handleImageSelectChange(selectedFile: File, isImage: boolean): Promise<void>
+onOpen(): void
+onClose(): void
}
note for CameraModal "Added filePicker2 and label2 for image capture"
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Added a second button specifically for capturing images from the camera app on mobile devices. |
|
src/Modal.ts |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review! - Generate a plan of action for an issue: Comment
@sourcery-ai planon an issue to generate a plan of action for it.
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.