obsidian-camera icon indicating copy to clipboard operation
obsidian-camera copied to clipboard

Add second Load button for Mobile

Open iBenMoore opened this issue 9 months ago • 1 comments

Add a second button for mobile devices, making the first for capturing "Video" from the camera app and the second for capturing"Images". This resolves the issues open for Android devices that currently can't capture images.

Summary by Sourcery

Add a separate button for capturing images on mobile devices, alongside the existing video capture button

New Features:

  • Introduce a second file upload button specifically for capturing images from the camera app on mobile devices

Bug Fixes:

  • Resolve image capture limitations for Android devices by adding a dedicated image upload button

Enhancements:

  • Modify the camera modal to support separate video and image capture buttons
  • Improve mobile file upload interface with distinct buttons for video and image capture

iBenMoore avatar Mar 31 '25 00:03 iBenMoore

Reviewer's Guide by Sourcery

This pull request adds a second 'Load' button for mobile devices to allow users to capture images directly from their camera app, addressing an issue where Android devices couldn't capture images. The existing button is now dedicated to capturing video.

Updated class diagram for CameraModal

classDiagram
  class CameraModal {
    +filePicker: HTMLInputElement
    +filePicker2: HTMLInputElement
    +label: HTMLLabelElement
    +label2: HTMLLabelElement
    +videoEl: HTMLVideoElement
    +mediaRecorder: MediaRecorder
    +chunks: BlobPart[]
    +handleImageSelectChange(selectedFile: File, isImage: boolean): Promise<void>
    +onOpen(): void
    +onClose(): void
  }
  note for CameraModal "Added filePicker2 and label2 for image capture"

File-Level Changes

Change Details Files
Added a second button specifically for capturing images from the camera app on mobile devices.
  • Added a new file input element with the id 'filepicker2'.
  • Set the 'accept' attribute of the new input to 'image/*' to filter for image files.
  • Created a new label element associated with the new input for capturing images.
  • Added an event listener to the new input element to handle the selected image file.
  • Modified the original file input element to only accept video files.
src/Modal.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar Mar 31 '25 00:03 sourcery-ai[bot]