Aldo Canepa Garay

Results 75 comments of Aldo Canepa Garay

hmm, @Tony-MK that is a good point, but I think that change would affect also the Old website leaving the currency empty, and that may break things there.

This still stuck on me, I have done some progress in reproducing the original problem in dev. The Expensiwork/smartscan was a bit tricky to get to work. I need to...

I found the code in the backend where we are setting the `modifiedCurrency` when smartscan fails and it is new code that was introduced for the new app. I don't...

hmm a test seems to be failing: ``` Summary of all failing tests FAIL tests/unit/TransactionUtilsTest.ts ● TransactionUtils › getCurrency › when the transaction has a receipt with a failed scan...

@wlegolas You can hold a bit on fixing the tests if you want, I wanted to explore a bit more the idea of fixing this in the backend now that...

> Hi @aldo-expensify do you have updates about it? Sorry not yet, I have been continuously kicking this for later, I'll try to check today or tomorrow.

I started doing some tests with Expensiworks and Smartscan yesterday, but I haven't been able to test properly this case yet.

For some reason when I test the FAILEDSCAN flow in dev, the transaction doesn't get a `modifiedCurrency`, so I can't reproduce the bug there. In staging it is getting `modifiedCurrency`...