Aldo Canepa Garay

Results 75 comments of Aldo Canepa Garay

Reproduced in dev disabling "reliable updates" for a `@gmail.com` account

~Seems like the personal details somehow go missing from onyx~. No, the report onyx update is missing in the `OpenReport` response, so we end up with the optimistic report only...

I think this is a product of my work moving the OpenReport onyx updates from Web-Expensify to Auth. These two PRs: https://github.com/Expensify/Web-Expensify/pull/41310 https://github.com/Expensify/Auth/pull/10226 That works based on the assumption that...

I merged this PR which should fix the problem once deployed: https://github.com/Expensify/Web-Expensify/pull/41588 Also, we are trying to get rid of the reliable updates beta asap, so that would have fixed...

> I think the only action is the get rid of the beta-- is that right? Thanks! This is fixed now, I just tested.

> This looks like it just adds translations. Does this need a C+ review? @c3024 It doesn't and I made this ready for review by mistake :P, sorry about that

> I said this in [Slack](https://expensify.slack.com/archives/C03TQ48KC/p1714421087411779), but I think we should get rid of the switch statement, create individual keys and use [translateIfPhraseKey](https://github.com/Expensify/App/blob/41ed79dd3542fef12993cfa5775f5130db79e0c2/src/libs/Localize/index.ts#L195) instead. Not gonna block this PR since...

> I am able to reproduce an unrelated error (not sure if it will happen w/o our internal back-end dev environment) @roryabraham yeah, I think when the backend sends that...

I have some doubts about the "Expected results" being correct here. If we say that the frontend is right, and the split creator name shouldn't appear in the report's last...

It is not clear to me from the conversation which option we want, so I asked here https://expensify.slack.com/archives/C05RECHFBEW/p1713833726038629 to confirm