dolphin-memory-engine icon indicating copy to clipboard operation
dolphin-memory-engine copied to clipboard

Bug/QoL: Array of Bytes Search Does Not Ignore Newlines

Open dreamsyntax opened this issue 4 months ago • 1 comments

To reproduce, use any region Shadow the Hedgehog with the below bytes in the Search field in "Array of Bytes" mode.

1:

38 00 00 32
90 1f 00 50
48 00 00 0c
38 00 00 3c
90 1f 00 50
80 01 00 14

2:

38 00 00 32 90 1f 00 50 48 00 00 0c 38 00 00 3c 90 1f 00 50 80 01 00 14

Alternatively craft your own array of bytes from functions on any game with a known match.

Both will look identical in the search box, but only 2 will return results. The newline is still 'used' in the search itself, but doesn't display in the text box.

Proposal: Either strip newlines, ignore them, or visibly show them in the text box.

Bonus: Also support array of bytes without spaces or arbitrary spaces, ex: 38000032901f00504800000c3800003c901f005080010014 or 38000032 901f0050 4800000c 3800003c 901f0050 80010014

As the most common usecase for this search type is sigscanning.

dreamsyntax avatar Jul 26 '25 18:07 dreamsyntax

Should update anything calling addSpacesToBytesArrays to also include other formatting logic \n etc

dreamsyntax avatar Aug 03 '25 15:08 dreamsyntax