hdf5-rust icon indicating copy to clipboard operation
hdf5-rust copied to clipboard
verified publisher icon aldanor

Use H5Pisa_class to circumvent bug

Open mulimoen opened this issue 3 years ago • 3 comments

Fixes #218. On the the bug in the issue memory usage decreases from 100MB++ to less than 50kB

@stormmathisen and @smutch Would be great if you tested this

mulimoen avatar Sep 05 '22 17:09 mulimoen

Hi @mulimoen. Thanks for looking in to this.

I can confirm a noticeable improvement for my small test run (3,819 groups with ~11,500 datasets).

Before: Screen Shot 2022-09-06 at 10 57 00

After: Screen Shot 2022-09-06 at 10 57 24

There is a large reduction in persistent 96 byte allocations.

smutch avatar Sep 06 '22 01:09 smutch

  • Probably makes sense to fix a few clippy complaints as well here?
  • Add this to changelog?
  • Why do you say it "partially" fixes #218? Wasn't this the root of the problem?

aldanor avatar Sep 28 '22 17:09 aldanor

There are enough breaking clippy complaints that I've opened #220 for those.

Added an entry to the changelog and changed the description of this PR

mulimoen avatar Sep 28 '22 19:09 mulimoen

Rebase on master?

aldanor avatar Oct 17 '22 15:10 aldanor

👍

aldanor avatar Oct 17 '22 20:10 aldanor