Patricio Palladino

Results 269 comments of Patricio Palladino

I'll make some progress on this PR while Luis is OOO. I rebased it on top of `core-in-hardhat-continuation`, and started working on simplifying it a bit, and on some TODOs.

Merging this as Luis is currently OOO. He'll continue working on this once he gets back.

> By default, pnpm does not automatically install peer dependencies. According to the docs it does install peer dependencies: https://pnpm.io/npmrc#auto-install-peers

I think you may be correct. I created this issue in the pnpm repo to better understand the situation: https://github.com/pnpm/pnpm/issues/8463

I believe you are right, @iosh, and we need to add pnpm to the doc and manually list most peer dependencies, at least the ones that the user would require/import.

> at least the ones that the user would require/import. We've got a confirmation from a maintainer of pnpm https://github.com/pnpm/pnpm/issues/8463#issuecomment-2325409745 > I want to contribute to Hardhat, but I am...

This is a good one: https://github.com/NomicFoundation/hardhat/issues/5696

Oops, I forgot to click the merge button

Hey, thanks for sending this PR. Can you explain it a bit? zksync isn't a development network. Are you trying to match a zksync dev-mode or something like that?