iso3166 icon indicating copy to clipboard operation
iso3166 copied to clipboard

needs documentation

Open alcohol opened this issue 8 years ago • 7 comments

I'm considering (either, or both) the following 2 options:

  • extend readme with some basic examples;
  • create api documentation and use the gh-pages branch.

alcohol avatar Jun 30 '16 11:06 alcohol

Any chance of getting some documentation on this? It's not at all clear how to use it as it stands?

robjbrain avatar Sep 13 '16 11:09 robjbrain

The chance is quite high. It is more a question of when. I have limited time available. Anyone can contribute this if they want to. Simply add relevant document(s) to the docs folder.

The first thing that should be documented is the interface (it is really quite trivial), which can be found in DataProvider.php.

After that, documentation can be extended to include details about how to load a customized dataset and such (but this is less important, cause anyone going down this path can probably figure it out from the code themselves).

alcohol avatar Sep 13 '16 12:09 alcohol

Idea: Run phpDocumentor over the project and publish to gh-pages? I know it is not an all inclusive solution but would provide a start. I'd be happy to do this for you @alcohol.

davidjeddy avatar Sep 21 '16 13:09 davidjeddy

That only provides a very basic API summary. I've added the interface methods already. You're free to add the phpdoc output to the existing docs. See the docs directory. I don't publish the docs through a gh-pages branch, since that is no longer necessary after the changes Github introduced.

alcohol avatar Sep 22 '16 06:09 alcohol

Per comment on https://github.com/thephpleague/iso3166/pull/30#issuecomment-249880823 ; what did you have in mind for documentation?

davidjeddy avatar Sep 28 '16 18:09 davidjeddy

Just another one or two pages on top of what is currently in docs/. A very brief description of the methods, their signature, and perhaps explaining what they do (if it isn't obvious from the name and signature yet).

alcohol avatar Sep 29 '16 05:09 alcohol

Ah, ok. Now I understand what you were looking for.

davidjeddy avatar Sep 29 '16 14:09 davidjeddy