BinaryDriver icon indicating copy to clipboard operation
BinaryDriver copied to clipboard

Dependencies broken

Open temp opened this issue 8 years ago • 2 comments

When installed with composer --prefer-lowest, the unit tests fail.

Examples:

  • Class 'Symfony\Component\Process\ProcessBuilder' not found
  • Class 'Symfony\Component\Process\ExecutableFinder' not found

Dependency to symfony/process should be at least raised to ^2.1.

temp avatar Jun 23 '17 16:06 temp

Any updates on this? IMO dependencies are broken even if you did not pass the --prefer-lowest arg.

As a dev who use PHPFFMPeg probe in a project, I noticed the trigger_error deprecation warning recently and start investigating.

  • FFProbeDriver::load calls the Alchemy\BinaryDriver\AbstractBinary::load
  • Then the ProcessBuilderFactory steps in and creates a symfony process builder in constuctor
  • ProcessBuilder is simply not available after the release of symfony/process::v3.4
  • There is no ProcessBuilder exist in symfony 4 or above.

This is an interesting issue, I could not decide if I should raise an issue on php-ffmpeg side or here at the beginning. Seems like even in latest version of this binary driver library, ProcessBuilder factory is assuming that ProcessBuilder is always exist which is wrong. IMO further investigation is needed since composer.json allows symfony 4 with a missing builder dependency.

edigu avatar Dec 01 '20 11:12 edigu

Oh. I found this issue which is highly related: https://github.com/PHP-FFMpeg/PHP-FFMpeg/issues/689

edigu avatar Dec 01 '20 11:12 edigu