no-tree-punching
no-tree-punching copied to clipboard
Fixing Fire Starter issues
Hello! :)
I am the developer of the Unlit Campfire mod and there was reported an compatibility issue with your mod. I found also some corresponding issues here in this repository.
- fixes https://github.com/cech12/UnlitCampfire/issues/59
- fixes https://github.com/alcatrazEscapee/no-tree-punching/issues/261
- fixes https://github.com/alcatrazEscapee/no-tree-punching/issues/269
Since I was at it, I also fixed a few other issues related to the fire positioning:
- fixes https://github.com/alcatrazEscapee/no-tree-punching/issues/326
- fixes https://github.com/alcatrazEscapee/no-tree-punching/issues/327
- fixes https://github.com/alcatrazEscapee/no-tree-punching/issues/113
Additionally I had an issue in getting your repository running. So, I updated the Epsilon version to 0.6, Gradle to 8.12 and ForgeGrade to 6.0.35 to fix that.
This PR fixes all these issues. Benefits of the changes:
- you don't need to look on top of a block. if you interact with a wall behind the items on the grond, the campfire ist also placed at the correct place.
- The rotation of a campfire placed by the fire starter tool is the same as when placing a campfire
- Placing fire behaves more like flint and steel. (replacement check "FireBlock.canBePlacedAt" is used)
- No non-full blocks will be replaced unless they are replaceable (like grass).
Overall this PR enhances the fire starter tool I hope, this project still gets updates and these changes can be published to enahance this beautiful mod. :)